Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rel noopener noreferrer nofollow to external link #209

Merged
merged 1 commit into from
Aug 21, 2017

Conversation

lmarcon
Copy link
Contributor

@lmarcon lmarcon commented Jul 23, 2017

With the current version of cookieconsent included in my website, Google Lighthouse raises a security warning related to external (target="_blank") links, lowering the score.

To fix it and follow the best practices, it's a good idea to include a rel="noopener" attribute in the external links, this PR adds it, along with nofollow and noreferrer.

Further info here: https://developers.google.com/web/tools/lighthouse/audits/noopener

@alexmorleyfinch alexmorleyfinch merged commit da01ade into osano:master Aug 21, 2017
@udos
Copy link

udos commented Feb 2, 2018

issue #185 is asking for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants