Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-342: insconfig #9

Merged
merged 5 commits into from
Aug 3, 2020
Merged

PLAT-342: insconfig #9

merged 5 commits into from
Aug 3, 2020

Conversation

AndreyBronin
Copy link
Contributor

@AndreyBronin AndreyBronin commented Aug 3, 2020

  • Have to rename config fields with underscore, insconfig lib doesn't recognize it

@codecov-commenter
Copy link

Codecov Report

Merging #9 into master will increase coverage by 1.37%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   66.55%   67.93%   +1.37%     
==========================================
  Files           6        6              
  Lines         308      315       +7     
==========================================
+ Hits          205      214       +9     
+ Misses         80       79       -1     
+ Partials       23       22       -1     
Impacted Files Coverage Δ
pkg/middleware/config.go 85.41% <92.85%> (+7.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e923225...9f6c1a5. Read the comment docs.

Copy link
Contributor

@yellowmegaman yellowmegaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWESOME!

@AndreyBronin AndreyBronin merged commit b543631 into master Aug 3, 2020
@AndreyBronin AndreyBronin deleted the PLAT-342-insconfig branch August 3, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants