Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend fsdb compatibility till v1.2.1 #277

Merged
merged 1 commit into from
Mar 26, 2016

Conversation

ael-code
Copy link
Member

No description provided.

@boyska
Copy link
Member

boyska commented Mar 24, 2016

Haven't tested it, but reading the fsdb git log I wonder what about the deep/depth parameter: isn't that a breaking change?

@boyska
Copy link
Member

boyska commented Mar 24, 2016

well, since the travis test is actually picking the most recent available version (that is, 1.1) and everything seems to work, there's no need to work. Just answer the question, rebase, and merge it yourself.

@ael-code ael-code changed the title extend fsdb compatibility till v1.1 extend fsdb compatibility till v1.2.1 Mar 25, 2016
@ael-code
Copy link
Member Author

Haven't tested it, but reading the fsdb git log I wonder what about the deep/depth parameter: isn't that a breaking change?

As stated in the changelog [0] this is not a breaking change.

[0] https://github.com/ael-code/pyFsdb/releases/tag/v1.2

@ael-code
Copy link
Member Author

I will give you some days to test it by yourself. Then I'll merge it.

@boyska boyska merged commit 07a92be into insomnia-lab:dev Mar 26, 2016
@ael-code ael-code deleted the pyfsdb_version branch April 3, 2016 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants