Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language autocompletion #288

Merged
merged 1 commit into from May 1, 2016
Merged

Add language autocompletion #288

merged 1 commit into from May 1, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2016

Closes #284

@boyska
Copy link
Member

boyska commented Apr 27, 2016

what happens if navitgator.language is empty, or if its value cannot be found in the language list?

except for this corner cases, seems good

@ghost
Copy link
Author

ghost commented Apr 27, 2016 via email

@boyska
Copy link
Member

boyska commented Apr 27, 2016

leonaard:

it just disappears the placeholder string

yeah, but I guess that if the user submit the volume, it could be with
an empty language, or with an invalid langcode

@ghost
Copy link
Author

ghost commented Apr 27, 2016 via email

@boyska
Copy link
Member

boyska commented Apr 27, 2016

the browser doesnt submit the form if there is no valid language, try it

I tried and it does. Since there is no practical way of forcing an
invalid language in firefox, I manually opened the firebug console and
typed document.getElementById('language').value = 'zz';
I sumbitted it, and it is added. I think that this should be prevented
client-side (server-side we should accept any two-letter code).

@boyska
Copy link
Member

boyska commented May 1, 2016

Oh, wait; it used to have the bug I reported, but now I see that everything is working fine, o0

merging

@boyska boyska merged commit 02204fe into insomnia-lab:dev May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant