Misc cleanup

[hugelgupf]

Based on #225. Some random stuff.

[hugelgupf]

This is where rtr7/router7#19 comes in.

[codecov]

Codecov Report

Merging #226 into master will increase coverage by 0.09%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##           master     #226      +/-   ##
==========================================
+ Coverage    72.3%   72.39%   +0.09%     
==========================================
  Files          84       83       -1     
  Lines        3676     3688      +12     
==========================================
+ Hits         2658     2670      +12     
  Misses        902      902              
  Partials      116      116

Impacted Files	Coverage Δ
dhcpv4/option_class_identifier.go	100% <ø> (ø)	⬆️
dhcpv4/option_host_name.go	100% <ø> (ø)	⬆️
dhcpv4/option_broadcast_address.go	100% <ø> (ø)	⬆️
dhcpv4/option_requested_ip_address.go	100% <ø> (ø)	⬆️
dhcpv4/option_root_path.go	100% <ø> (ø)	⬆️
dhcpv4/option_domain_name.go	100% <ø> (ø)	⬆️
dhcpv4/option_vivc.go	100% <ø> (ø)	⬆️
dhcpv4/option_userclass.go	100% <ø> (ø)	⬆️
dhcpv4/option_server_identifier.go	100% <ø> (ø)	⬆️
dhcpv4/option_tftp_server_name.go	100% <ø> (ø)	⬆️
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a987c...a955d74. Read the comment docs.

[insomniacslk]

Looks good to me, thanks! Another excellent improvement.
Once the OptVersion build failure is addressed this can be merged

[pmazzini]

LGTM, thanks! Not merging yet to give @insomniacslk a chance to look at it.

[pmazzini]

@insomniacslk I wanted to go ahead with the merge to avoid blocking @hugelgupf but I can't since this PR breaks the router7 build, which will be fixed with rtr7/router7#19. Do I have permission to merge it even if the travis build fails?

[hugelgupf]

You're gonna have to - rtr7 doesnt use vendor or modules. And I can't submit both PRs together as one. And this dhcp one has to come first.

[insomniacslk]

as @hugelgupf said - this PR has to be merged first, then @stapelberg will have to merge rtr7/router7#19

[pmazzini]

Yes, I was willing to do that but the merge button was blocked. Thanks for merging it!