Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circular dependency on u-root #429

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

hugelgupf
Copy link
Collaborator

@hugelgupf hugelgupf commented May 28, 2021

u-root -> dhcp -> u-root is the circular dependency. Which is fine,
except we messed up modules in u-root big time. We need to break the
circular dep for now.

One warning!

uio does not use "uroot.nohwrng" on the cmdline anymore. Now, UROOT_NOHWRNG=$anything has to be specified in the environment (and one can put that in the cmdline as well, actually)

u-root -> dhcp -> u-root is the circular dependency. Which is fine,
except we messed up modules in u-root big time. We need to break the
circular dep for now.

Signed-off-by: Chris Koch <chrisko@google.com>
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #429 (7817cfd) into master (95b2ff6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files          88       88           
  Lines        3665     3665           
=======================================
  Hits         2471     2471           
  Misses       1030     1030           
  Partials      164      164           
Flag Coverage Δ
integtests ∅ <ø> (∅)
unittests 67.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dhcpv4/bsdp/boot_image.go 73.80% <ø> (ø)
dhcpv4/bsdp/bsdp_option_boot_image_list.go 100.00% <ø> (ø)
dhcpv4/bsdp/bsdp_option_message_type.go 100.00% <ø> (ø)
dhcpv4/bsdp/bsdp_option_misc.go 100.00% <ø> (ø)
dhcpv4/dhcpv4.go 74.49% <ø> (ø)
dhcpv4/nclient4/conn_linux.go 62.22% <ø> (ø)
dhcpv4/nclient4/ipv4.go 95.77% <ø> (ø)
dhcpv4/option_ip.go 86.66% <ø> (ø)
dhcpv4/option_ip_address_lease_time.go 100.00% <ø> (ø)
dhcpv4/option_ips.go 100.00% <ø> (ø)
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b2ff6...7817cfd. Read the comment docs.

Copy link

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no authority to approve this.

Copy link
Collaborator

@pmazzini pmazzini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hugelgupf hugelgupf merged commit fb4eaaa into insomniacslk:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants