-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
soumyo/aws_cloudfront_cache_policy #644
Conversation
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
690d768
to
8dcbf02
Compare
Your [Principal](https://docs.aws.amazon.com/IAM/latest/UserGuide/intro-structure.html#intro-structure-principal) will need the `CloudFront:Client:Getcache policyResult` action with `Effect` set to `Allow`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be "CloudFront:Client:GetCachePolicyResult". Please check.
Link to refer: https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/CloudFront/Client.html#get_cache_policy-instance_method
@IanMadd If no changes are required, Can you please approve the PR so that we can merge it to the main branch? |
Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: Soumyodeep Karmakar soumyo.k13@gmail.com
Description
It contains all the singular and plural resources of the above resource.
Issues Resolved
This is a new resource. There are no issues to be fixed.
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lint
passes