Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

soumyo/aws_cloudfront_cache_policy #644

Merged
merged 6 commits into from
Oct 28, 2021
Merged

Conversation

soumyo13
Copy link
Contributor

Signed-off-by: Soumyodeep Karmakar soumyo.k13@gmail.com

Description

It contains all the singular and plural resources of the above resource.

Issues Resolved

This is a new resource. There are no issues to be fixed.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 requested review from a team as code owners September 17, 2021 14:09
@soumyo13 soumyo13 self-assigned this Sep 17, 2021
@soumyo13 soumyo13 linked an issue Sep 17, 2021 that may be closed by this pull request
@Nirbhay1997 Nirbhay1997 added the wip WORK in Progress label Sep 17, 2021
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@soumyo13 soumyo13 removed the wip WORK in Progress label Sep 18, 2021
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ian Maddaus <Ian.Maddaus@progress.com>
@IanMadd IanMadd force-pushed the soumyo/aws_cloudfront_cache_policy branch from 690d768 to 8dcbf02 Compare October 7, 2021 20:10
Your [Principal](https://docs.aws.amazon.com/IAM/latest/UserGuide/intro-structure.html#intro-structure-principal) will need the `CloudFront:Client:Getcache policyResult` action with `Effect` set to `Allow`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be "CloudFront:Client:GetCachePolicyResult". Please check.

Link to refer: https://docs.aws.amazon.com/sdk-for-ruby/v3/api/Aws/CloudFront/Client.html#get_cache_policy-instance_method

@soumyo13
Copy link
Contributor Author

@IanMadd If no changes are required, Can you please approve the PR so that we can merge it to the main branch?

Signed-off-by: Ian Maddaus <ian.maddaus@progress.com>
Signed-off-by: Soumyodeep Karmakar <soumyo.k13@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@soumyo13 soumyo13 merged commit 2b021a3 into main Oct 28, 2021
@soumyo13 soumyo13 deleted the soumyo/aws_cloudfront_cache_policy branch October 28, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS::CloudFront::CachePolicy
3 participants