Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nirbhay/DB Cluster snapshots #696

Merged
merged 5 commits into from
Oct 27, 2021
Merged

Nirbhay/DB Cluster snapshots #696

merged 5 commits into from
Oct 27, 2021

Conversation

Nirbhay1997
Copy link
Contributor

@Nirbhay1997 Nirbhay1997 commented Oct 19, 2021

Description

This is a new resource that enables us to audit RDS DB Cluster Snapshots/Snapshot.

Issues Resolved

#691

Check List

Please fill box or appropriate ([x]) or mark N/A.

Nirbhay Kumar added 2 commits October 19, 2021 15:26
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nirbhay1997 Nirbhay1997 self-assigned this Oct 19, 2021
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
|percent_progress | Specifies the percentage of the estimated data that has been transferred. |
|storage_encrypted | Specifies whether the DB cluster snapshot is encrypted. |
|kms_key_id | If StorageEncrypted is true, the AWS KMS key identifier for the encrypted DB cluster snapshot. |
|db_cluster_snapshot_arn | The Amazon Resource Name (ARN) for the DB cluster snapshot.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nirbhay1997 : Same here.

would be please explain more about source_db_cluster_snapshot_arn . the description seems wrong and also I couldn't trace that out in the reference provided in the .md file - https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithParamGroups.html

@dkumaras

|snapshot_types | Provides the type of the DB cluster snapshot. | snapshot_type |
|percent_progresses | Specifies the percentage of the estimated data that has been transferred. | percent_progress |
|storage_encrypted | Specifies whether the DB cluster snapshot is encrypted. | storage_encrypted |
|kms_key_ids | If StorageEncrypted is true, the AWS KMS key identifier for the encrypted DB cluster snapshot. | kms_key_id |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, same here

|storage_encrypted | Specifies whether the DB cluster snapshot is encrypted. | storage_encrypted |
|kms_key_ids | If StorageEncrypted is true, the AWS KMS key identifier for the encrypted DB cluster snapshot. | kms_key_id |
|db_cluster_snapshot_arns | The Amazon Resource Name (ARN) for the DB cluster snapshot.| db_cluster_snapshot_arn |
|source_db_cluster_snapshot_arns | If the DB cluster snapshot was copied from a source DB cluster snapshot, the Amazon Resource Name (ARN) for the source DB cluster snapshot, otherwise, a null value. | source_db_cluster_snapshot_arn |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here too.. the description is not clear. Please check.

@soumyo13
Copy link
Contributor

@dkumaras Here is the link where we referenced the descriptions.

Link: https://awscli.amazonaws.com/v2/documentation/api/latest/reference/rds/describe-db-cluster-snapshots.html

Please let me know if you need more information.

image

Signed-off-by: Nirbhay Kumar <nkumar@progress.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nirbhay1997 Nirbhay1997 merged commit 1862466 into main Oct 27, 2021
@Nirbhay1997 Nirbhay1997 deleted the NIrbhay/DBSnapshots branch October 27, 2021 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS RDS (Relational Database Service) Snapshot should not have access for unmonitored cloud accounts
3 participants