-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request for CloudFormation Template #770
Feature request for CloudFormation Template #770
Conversation
Signed-off-by: Josh Bowman <joshua.bowman@sap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the comment.
Recommended changes to documentation Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
My fault, hadn't updated the branch. Sorry about that. |
Co-authored-by: Ian Maddaus <IanMadd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi , @jb897 could you please update the tests with this attribute?
|
@jb897 could you please add unit tests and integration tests for the attribute? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
As requested by @jonlives in the slack channel, to unblock current implementation of the controls by the customer, approving this one! Tests for this either way is a minor one and can be part of a separate PR .. Hey @jb897, please raise a separate PR for the tests once you are done with the implementation of them.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
since this is blocking customer
Hi @jb897, The attribute |
Hi @Nirbhay1997, I hadn't realized I've been adding this locally, do you still want me to make a PR to include this in the resource pack? Apologies for the late response. |
Signed-off-by: Josh Bowman joshua.bowman@sap.com
Description
This change allows the template_body property to be accessed from the aws_cloudformation_template resource.
Another AWS SDK API call to get_template is added, along with a function to retrieve the data stored. One caveat, is that the stack_name parameter must be used in the resource, since this is the only parameter that the API call will accept related to the cloudformation_templates
Issues Resolved
Needed to access information from the template body when accessing a cloudformation_template.
Check List
Please fill box or appropriate ([x]) or mark N/A.
rake lint
passes