Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for CloudFormation Template #770

Merged

Conversation

jb897
Copy link
Contributor

@jb897 jb897 commented Nov 19, 2021

Signed-off-by: Josh Bowman joshua.bowman@sap.com

Description

This change allows the template_body property to be accessed from the aws_cloudformation_template resource.
Another AWS SDK API call to get_template is added, along with a function to retrieve the data stored. One caveat, is that the stack_name parameter must be used in the resource, since this is the only parameter that the API call will accept related to the cloudformation_templates

Issues Resolved

Needed to access information from the template body when accessing a cloudformation_template.

Check List

Please fill box or appropriate ([x]) or mark N/A.

Signed-off-by: Josh Bowman <joshua.bowman@sap.com>
@jb897 jb897 requested review from a team as code owners November 19, 2021 16:41
Copy link
Contributor

@soumyo13 soumyo13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment.

docs/resources/aws_cloudformation_template.md Outdated Show resolved Hide resolved
jb897 and others added 2 commits November 22, 2021 10:00
Recommended changes to documentation

Co-authored-by: Soumyodeep Karmakar <63713087+soumyo13@users.noreply.github.com>
@jb897
Copy link
Contributor Author

jb897 commented Nov 23, 2021

My fault, hadn't updated the branch. Sorry about that.

Copy link
Contributor

@Nirbhay1997 Nirbhay1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi , @jb897 could you please update the tests with this attribute?

@jb897
Copy link
Contributor Author

jb897 commented Nov 30, 2021

Sorry for the delay. Was out of office due to Thanksgiving.

@Nirbhay1997
Copy link
Contributor

@jb897 could you please add unit tests and integration tests for the attribute?

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@sathish-progress
Copy link
Contributor

@jb897 could you please add unit tests and integration tests for the attribute?

As requested by @jonlives in the slack channel, to unblock current implementation of the controls by the customer, approving this one! Tests for this either way is a minor one and can be part of a separate PR ..

Hey @jb897, please raise a separate PR for the tests once you are done with the implementation of them..

Copy link
Contributor

@sathish-progress sathish-progress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sathish-progress sathish-progress dismissed soumyo13’s stale review December 6, 2021 19:34

since this is blocking customer

@sathish-progress sathish-progress merged commit 4b81a7b into inspec:main Dec 6, 2021
@Nirbhay1997
Copy link
Contributor

Hi @jb897, The attribute template_body is not working for me instead I need to use it like this
template_body.template_body. Could you please parse it properly so that we can use template_body ??

@jb897
Copy link
Contributor Author

jb897 commented Dec 10, 2021

Hi @jb897, The attribute template_body is not working for me instead I need to use it like this template_body.template_body. Could you please parse it properly so that we can use template_body ??

Hi @Nirbhay1997, I hadn't realized I've been adding this locally, do you still want me to make a PR to include this in the resource pack? Apologies for the late response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants