Add lib for mysql server and mysql database #160
Conversation
Signed-off-by: root <root@DESKTOP-9Q2U73J.localdomain>
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
Signed-off-by: Mikael Krief <krief_mikael@hotmail.com>
|
Thank you for your contribution! I'll work with @r-fennell and make sure one of us gets this reviewed. |
There was a problem hiding this comment.
Hi @mikaelkrief !
Thank you for this useful contribution. I look forward to merging this and adding the new functionality you have introduced. I've left a few minor change requests - if there is anything you require clarification or assistance with feel free to reply directly or reach out to me on the Chef Community Slack.
Ruairi
| 'az', 'account', | ||
| 'set', | ||
| '--subscription', ENV['AZURE_SUBSCRIPTION_ID'] | ||
| ) |
There was a problem hiding this comment.
👍 - Useful for those juggling multiple AZ accounts.
Rakefile
Outdated
| @@ -131,7 +137,7 @@ namespace :test do | |||
| task :integration, [:controls] => [:check_attributes_file] do |_t, args| | |||
| cmd = %W( bin/inspec exec test/integration/verify | |||
| --attrs terraform/#{ENV['ATTRIBUTES_FILE']} | |||
| --reporter progress | |||
| --reporter cli | |||
There was a problem hiding this comment.
Can I ask the reasoning behind this? We switched to the progress reporter because generally we only want to know when something has gone wrong, and the cli reporter can be very verbose (especially in CI logs).
I'd rather stick to progress unless you have found a pressing need for it.
| @@ -117,6 +117,9 @@ To determine which properties are available for a given resource, start by looki | |||
|
|
|||
| ## Create documentation in `docs/resources` | |||
| Once everything is working, documentation must be added for the resources that have been added. Copy similar resource documents in `docs/resources/` and edit them as appropriate. Include enough examples to give a good idea how the resource works. Make sure to include any special case examples that might exist. | |||
| After writing the documentation: | |||
| - Run `bundle exec rake docs:resource_links` | |||
| - Copy/Paste all display links in the Readme.md | |||
|
|
||
| ### Version | ||
|
|
||
| This resource first became available in 1.2.0 of the inspec-azure resource pack. |
There was a problem hiding this comment.
This can be bumped to 1.3.0 - we will release after this addition.
|
|
||
| ### Version | ||
|
|
||
| This resource first became available in 1.2.0 of the inspec-azure resource pack. |
There was a problem hiding this comment.
This can be bumped to 1.3.0 - we will release after this addition.
lib/environment_file.rb
Outdated
| @@ -4,6 +4,7 @@ class EnvironmentFile | |||
| network_watcher | |||
| msi | |||
| sql | |||
| mysql | |||
There was a problem hiding this comment.
This is fine to bundle with the sql option. You can update your controls to only_if { ENV['SQL'] }
terraform/azure.tf
Outdated
| resource_group_name = "${azurerm_resource_group.rg.name}" | ||
|
|
||
| sku { | ||
| name = "${var.sku_name}" |
There was a problem hiding this comment.
If the variables being referenced here (in variables.tf) are not reused, we should simply hardcode the values in azure.tf until they're needed in multiple places. I dont expect we will need to reuse any the MySQL values.
terraform/variables.tf
Outdated
| @@ -73,3 +73,71 @@ variable "public_vm_count" { | |||
| variable "sql-server-version" { | |||
| default = "12.0" | |||
| } | |||
|
|
|||
|
|
|||
| # Azure mysql | |||
There was a problem hiding this comment.
As above, it's fine to hardcode most/all of these straight into the terraform resource, unless they are being used in several places!
|
|
||
| describe azurerm_mysql_database(resource_group: resource_group, | ||
| server_name: mysql_server_name, | ||
| database_name: mysql_db_name) do |
|
@r-fennell Thanks, I fixed and pushed all this feedbacks |
|
Hi, |
ghost
closed this
Description
Add azurerm test librairies for:
include: