Update iis_site bindingInformation construction and add tests

[mrshanahan]

Signed-off-by: Matt Shanahan mrshanahan11235@gmail.com

I have not made any changes to the docs, since this brings the code in line with the documentation. Also added some unit tests to the iis_site resource.

Relevant resource docs: https://github.com/inspec/inspec/blob/master/docs/resources/iis_site.md.erb#L109-L139

Fixes #3490
EDIT (@clintoncwolfe): Move reference to issue from PR title to description to trigger close-on-merge.

[aaronlippold]

hi, given that you document at least twice that you only support 2012+, would it be a good idea to add that as part of the platforms lotic in the init method of the resource?

[mrshanahan]

@aaronlippold That makes sense! Let me take a look.

[miah]

@mrshanahan, @aaronlippold

We're moving away from doing platform support restrictions in initialize. This should all be handled by the supports dsl now.

We could do something like:

supports platform: 'windows', release: '6.2.*'

Where release is the right version number =) Note that you can add multiple supports, so you should be able to cover all the platforms.

[aaronlippold]

I agree for the profile for iis. But for the initialization of the iis resource itself shouldn't we still have that fail fast?

[mrshanahan]

I'm happy to add the appropriate supports statements to narrow down the acceptable list of platforms, but I'm not sure how to find what the available platform names are. Can I select e.g. windows_server instead of windows? I had some trouble finding the relevant code.

[jquick]

@mrshanahan , The windows specific names ones are a bit dynamic and end up being something like windows_server_2012_r2_standard_evaluation. I would stick with something like what @miah suggested. The release portion should contain it only to the ones we want.

We use this command to find the windows release https://github.com/inspec/train/blob/master/lib/train/platforms/detect/helpers/os_windows.rb#L6

[clintoncwolfe]

Thanks so much! This is a great first contribution, and we really appreciate it. There is some concern about restricting the releases on which the resource will run, but your PR is independent of that concern; I've opened #3591 to track needing to tighten the platform support, and that clears the way to get this merged in.

Thanks!

[jquick]

Thanks @mrshanahan

[mrshanahan]

Thank you!