Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with webmock 3+ #3939

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Test with webmock 3+ #3939

merged 1 commit into from
Apr 12, 2019

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Apr 11, 2019

Webmock 2.x does not support Ruby 2.6.

Signed-off-by: Tim Smith tsmith@chef.io

@tas50
Attempt to switch to new webmock that supports Ruby 2.6+
501a390 
Signed-off-by: Tim Smith <tsmith@chef.io>
clintoncwolfe
clintoncwolfe approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clintoncwolfe clintoncwolfe merged commit ce9fe22 into master Apr 12, 2019
@clintoncwolfe clintoncwolfe deleted the new_webmock branch April 12, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tas50 @miah @clintoncwolfe