group resource: Modified DarwinGroup to collect all users properly on macos #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miah
suggested changes
Jul 30, 2019
|
And probably to convert everything over to command resources? This was sloppy and only tested locally. Not sure HOW to test this tbh.. BK doesn't do mac yet. |
clintoncwolfe
requested changes
Jul 31, 2019
zenspider
force-pushed
the
zenspider/osx-groups
branch
2 times, most recently
from
0a9cbf8
to
800eca4
Compare
miah
approved these changes
Aug 8, 2019
I noticed that my profile targeting group "staff" on OSX wasn't returning *me*. I'm awesome! So that seemed wrong. And it turns out it is wrong. We were not collecting any users whose primary group was that group. (almost all regular users are in group staff and they're all missing). Signed-off-by: Ryan Davis <zenspider@chef.io>
zenspider
force-pushed
the
zenspider/osx-groups
branch
from
800eca4
to
374e365
Compare
|
Code Climate has analyzed commit 374e365 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
clintoncwolfe
approved these changes
Aug 8, 2019
clintoncwolfe
added
Platform: macOS
Component: Core Resources
clintoncwolfe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my profile targeting group "staff" on OSX wasn't
returning ME. That seemed wrong. And it turns out it is wrong. We were
not collecting any users whose primary group was that group. (almost
all regular users are in group staff and they're all missing).
I ALSO found out that our MockLoader-based testing is piss-poor and,
through much pain and suffering, figured out how to test the group
resource directly.
Signed-off-by: Ryan Davis zenspider@chef.io