Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for tests under ruby 2.7 #4970

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Fixes for tests under ruby 2.7 #4970

merged 2 commits into from
Apr 9, 2020

Conversation

clintoncwolfe
Copy link
Contributor

@clintoncwolfe clintoncwolfe commented Apr 6, 2020 •
edited
Loading

Description

  1. Enable the tests under ruby 2.7 by removing the ||true buildkite failsafe.
  2. Found that 5 tests were failing due to deprecation warnings from fileutils and rubygems during plugin testing. Added a custom assertion to filter stderr.
  3. The final failing test is in train. I've opened train#582 to fix that, but this PR won't be clean until that is merged.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@clintoncwolfe
Make ruby 2.7 tests meaningful
e776337 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe added Type: Bug Feature not working as expected Aspect: Testing labels Apr 6, 2020
@clintoncwolfe clintoncwolfe requested a review from a team as a code owner April 6, 2020 22:35
@clintoncwolfe clintoncwolfe force-pushed the cw/fix-2.7-tests branch 2 times, most recently from 1770d77 to a8b0476 Compare April 8, 2020 14:54
@clintoncwolfe
Ignore deprecation warning in fileutils and rubygems gems under ruby 2.7
a8b0476 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
james-stocks
james-stocks approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@james-stocks james-stocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks @clintoncwolfe :)

@clintoncwolfe clintoncwolfe merged commit 4f61e37 into master Apr 9, 2020
@clintoncwolfe clintoncwolfe deleted the cw/fix-2.7-tests branch April 9, 2020 16:17
@kvivek1115 kvivek1115 mentioned this pull request May 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-stocks james-stocks james-stocks approved these changes

@stevendanna stevendanna Awaiting requested review from stevendanna

Assignees

@clintoncwolfe clintoncwolfe

Labels
Aspect: Testing Type: Bug Feature not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintoncwolfe @james-stocks