CFINSPEC-70 Added resource_id attribute for the custom resources in the base class #5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for chef-inspec ready! 🔨 Explore the source changes: bb410b8 🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-inspec/deploys/6220fb35f6bb9a0007dce65e 😎 Browse the preview: https://deploy-preview-5875--chef-inspec.netlify.app/inspec/dsl_resource |
Nik08
changed the title
Nik08
force-pushed
the
nm/base_resource_id
branch
from
d756fae
to
cb87710
Compare
lib/inspec/resource.rb
Outdated
| @@ -34,6 +34,11 @@ def self.supports(criteria = nil) | |||
| Inspec::Resource.support_registry[key].push(criteria) | |||
| end | |||
|
|
|||
| def resource_id(value = nil) | |||
| resource_id_value = value || "" | |||
| @resource_id ||= resource_id_value | |||
There was a problem hiding this comment.
This logic makes the instance variable write-once. That seems like a subtle bug to me.
res.resource_id('a')
res.resource_id => 'a'
res.resource_id('b')
res.resource_id => 'a' # this is surprising
| @@ -48,6 +48,7 @@ The following attributes can be configured: | |||
| - desc - Description of the resource (optional) | |||
| - example - Example usage of the resource (optional) | |||
| - supports - (Chef InSpec 2.0+) Platform restrictions of the resource (optional) | |||
| - resource_id - A unique identifier for each node of resource. Should specify the implementation to determine it (optional) | |||
There was a problem hiding this comment.
I think this needs to be separated out from the rest of the DSL. It should be clearer that this is not a DSL method you can call on your own as a DSL method, but a method you have to call as an instance method in your resource.
clintoncwolfe
approved these changes
Mar 3, 2022
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
…hema Signed-off-by: Nikita Mathur <nikita.mathur@chef.io>
clintoncwolfe
force-pushed
the
nm/base_resource_id
branch
from
b591644
to
bb410b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikita Mathur nikita.mathur@chef.io
Description
Related Issue
Types of changes
Checklist: