Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport firewalld update - inspec-4 #5919

Merged
merged 9 commits into from
Mar 11, 2022
Merged

Backport firewalld update - inspec-4 #5919

merged 9 commits into from
Mar 11, 2022

Conversation

clintoncwolfe
Copy link
Contributor

Cherry-picks #5597 to inspec-4 branch. Thanks @wdower !

Description

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

Daniel Tingstrom and others added 9 commits March 10, 2022 15:45
@clintoncwolfe
Update firewalld resource to include more properties
3b1c850 
Signed-off-by: Daniel Tingstrom <dtingstrom@mitre.org>
@clintoncwolfe
Fix boolean function declarations/references to include a '?'
5637f27 
Signed-off-by: Daniel Tingstrom <dtingstrom@mitre.org>
@clintoncwolfe
Fix boolean methods to include a '?'
ebea7f9 
Signed-off-by: Daniel Tingstrom <dtingstrom@mitre.org>
@wdower @clintoncwolfe
wip on adding custom matchers to the resource
eb2a1c2 
Signed-off-by: Will Dower <wdower@mitre.org>
@wdower @clintoncwolfe
add
513b743 
Signed-off-by: Will Dower <wdower@mitre.org>
@wdower @clintoncwolfe
updated docs for resource
d00ce2c 
Signed-off-by: Will Dower <wdower@mitre.org>
@wdower @clintoncwolfe
changed array style at chefstyle's request
d0e13b4 
Signed-off-by: Will Dower <wdower@mitre.org>
@dkumaras @clintoncwolfe
#5597 edits
06dccd2 
Signed-off-by: Deepa Kumaraswamy <dkumaras@progress.com>
@wdower @clintoncwolfe
combined Properties and Property Examples
834572f 
Signed-off-by: Will Dower <wdower@mitre.org>
@clintoncwolfe clintoncwolfe requested review from a team as code owners March 10, 2022 20:53
@github-actions github-actions bot added the Documentation ZH multi-repo label for the docs-team label Mar 10, 2022
@clintoncwolfe clintoncwolfe merged commit 423f76a into inspec-4 Mar 11, 2022
@clintoncwolfe clintoncwolfe deleted the cw/backport-firewalld-update branch March 11, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vasu1105 Vasu1105 Awaiting requested review from Vasu1105 Vasu1105 is a code owner automatically assigned from inspec/inspec-core-team

@Nik08 Nik08 Awaiting requested review from Nik08 Nik08 is a code owner automatically assigned from inspec/inspec-core-team

Assignees

@clintoncwolfe clintoncwolfe

Labels
Documentation ZH multi-repo label for the docs-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clintoncwolfe @wdower @dkumaras