Tweak logging for clarity #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @chris-rock |
tduffield
force-pushed
the
tduffield/tweak-logging-for-clarity
branch
4 times, most recently
from
ab71f7c
to
efb5063
Compare
Do not print an info message saying that we are loading tests from the test_base_dir unless we actually are. This can be confusing for first-time users who may not even have that directory (if they used ChefDK to generate the .kitchen.yml). Rather, iterate through the targets that we _are_ testing and log those. Signed-off-by: Tom Duffield <tom@chef.io>
tduffield
force-pushed
the
tduffield/tweak-logging-for-clarity
branch
from
efb5063
to
26e01ec
Compare
chris-rock
force-pushed
the
tduffield/tweak-logging-for-clarity
branch
from
09d3f4b
to
d9183ff
Compare
|
Awesome @tduffield I like to idea to show more logging via kitchen-inspec. On top of your commit I:
If you need more details I rather like to fix that in InSpec, so that we do not duplicate parsing the information |
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
tduffield/tweak-logging-for-clarity
branch
from
d9183ff
to
d60073c
Compare
chris-rock
approved these changes
Dec 8, 2016
|
@tduffield If you are okay with my changes, we can merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not print an info message saying that we are loading tests from the
test_base_dir unless we actually are. This can be confusing for
first-time users who may not even have that directory (if they used
ChefDK to generate the .kitchen.yml). Rather, iterate through the
targets that we are testing and log those.
Signed-off-by: Tom Duffield tom@chef.io