Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly configure HTTPS WinRM #153

Merged
merged 1 commit into from
Dec 5, 2017
Merged

correctly configure HTTPS WinRM #153

merged 1 commit into from
Dec 5, 2017

Conversation

joekhoobyar
Copy link
Contributor

@joekhoobyar joekhoobyar commented Dec 3, 2017

This fixes Issue #152, by analyzing the proper parts of the Kitchen Transport connection options and applying them to the runner options for winrm.

Fixes #152

@joekhoobyar joekhoobyar requested a review from a team as a code owner December 3, 2017 01:31
Signed-off-by: Joe Khoobyar <joe@khoobyar.name>
@adamleff adamleff changed the title fixes #152: correctly configure HTTPS WinRM correctly configure HTTPS WinRM Dec 5, 2017
Copy link
Contributor

@adamleff adamleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks, @joekhoobyar!

Copy link
Collaborator

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet catch @joekhoobyar !! thank you :)

@arlimus arlimus merged commit 870bb79 into inspec:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kitchen-inspec fails to configure HTTPS winrm for inspec
3 participants