Add the InSpec backend_cache option #155
Conversation
Signed-off-by: Jared Quick <jquick@chef.io>
jquick
force-pushed
the
jq/add_backend_cache_option
branch
from
53c401c
to
918ddef
Compare
lib/kitchen/verifier/inspec.rb
Outdated
| backend_cache_msg = "backend_cache requires InSpec version >= 1.47.0" | ||
| logger.warn backend_cache_msg if Gem::Version.new(::Inspec::VERSION) < Gem::Version.new("1.47.0") | ||
| end | ||
| runner_options[:backend_cache] = config[:backend_cache].nil? ? true : config[:backend_cache] |
There was a problem hiding this comment.
This places the default behavior of the caching in two places - InSpec, and kitchen-inspec. And technically, this is a breaking change by defaulting it to true. We can get away with that since we're still technically 0.x SemVer version, but I still think it's the wrong choice.
I think it would be better to let this logic live with InSpec until there's a specific use case where we have to deviate the default behavior. Therefore, I'd change this to be:
if config[:backend_cache]
backend_cache_msg = "backend_cache requires InSpec version >= 1.47.0"
logger.warn backend_cache_msg if Gem::Version.new(::Inspec::VERSION) < Gem::Version.new("1.47.0")
runner_options[:backend_cache] = config[:backend_cache]
endThere was a problem hiding this comment.
After talking it over with Adam we decided to have it default to false here. This is due to how we are grabbing the internals of inspec without going through the normal default option initiation.
spec/kitchen/verifier/inspec_spec.rb
Outdated
| expect(config.to_hash).to include(backend_cache: false) | ||
| end | ||
|
|
||
| it "backend_cache option defaults to true" do |
There was a problem hiding this comment.
This test will need to be updated if you take my advice, obviously :)
Signed-off-by: Jared Quick <jquick@chef.io>
|
@adamleff - This is ready for another look. |
Fixes #154
This PR introduces the new backend_cache option. This flag will default to true if not defined in your kitchen.yml.
Signed-off-by: Jared Quick jquick@chef.io