Require Ruby 2.1+ #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| spec.add_dependency "inspec", ">=0.22.0", "<1.0.0" | ||
| spec.add_dependency "test-kitchen", "~> 1.6" | ||
| spec.add_development_dependency "countloc", "~> 0.4" | ||
| spec.add_development_dependency "bundler", "~> 1.10" | ||
| spec.add_development_dependency "rake", "~> 10.0" | ||
| spec.add_development_dependency "rake", "~> 11.0" |
There was a problem hiding this comment.
I think we should remove the development dependencies from gemspec and place them into gemfile. @tas50 What do you think?
I think we should only have:
spec.add_dependency "inspec", ">=0.22.0", "<1.0.0"
spec.add_dependency "test-kitchen", "~> 1.6"
here
There was a problem hiding this comment.
We've moved to putting our dev deps in the Gemfile. I'm totally fine with that. I didn't want to change things to much in this PR since I wasn't sure how you folks like to do things, but I can make that change now that I know you're OK with it.
|
@chris-rock This should be good to go now |
Signed-off-by: Tim Smith <tsmith@chef.io>
|
Thanks for the improvement @tas50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 1.9 and 2.0 are EOL and we shouldn't be supporting them anymore.
#98 needs to get merged first for this to make sense