Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide uri-formatted information on all connections #113

Merged
merged 1 commit into from
Jun 16, 2016
Merged

Conversation

arlimus
Copy link
Contributor

@arlimus arlimus commented Jun 16, 2016

Since Train provides Train.target_config( ... ) which resolves target URIs to their transports, this PR provides the a mechanism to reverse the direction and go from Connection to URI.

@arlimus
Copy link
Contributor Author

arlimus commented Jun 16, 2016

The reason this doesn't use to_s is that this function currently offers all options configured with a Connection in its output. This continues to be very helpful and shouldn't change. At the same time it is too much information for a simple URI pattern. Finally, it can potentially expose passwords and other secrets which this MR keeps to a minimum (i.e. don't show passwords or keys).

@arlimus arlimus force-pushed the dr/uri branch 2 times, most recently from 3cf8cce to 58c2419 Compare June 16, 2016 07:46
@chris-rock
Copy link
Contributor

Very useful addition @arlimus

@chris-rock chris-rock merged commit 60bff34 into master Jun 16, 2016
@arlimus arlimus deleted the dr/uri branch June 16, 2016 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants