New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial import of transport for GCP. #283

Merged
merged 7 commits into from May 14, 2018

Conversation

Projects
None yet
4 participants
@skpaterson
Copy link
Member

skpaterson commented Apr 16, 2018

Add transport for Google Cloud Platform. Note, this introduces a gem dependency issue with berkshelf.

Initial import of transport for GCP.
Signed-off-by: Stuart Paterson <spaterson@chef.io>

@skpaterson skpaterson requested a review from jquick Apr 16, 2018

@skpaterson skpaterson requested a review from chef/train-maintainers as a code owner Apr 16, 2018

@adamhjk adamhjk added the in progress label Apr 16, 2018

@clintoncwolfe

This comment has been minimized.

Copy link
Contributor

clintoncwolfe commented Apr 16, 2018

@jquick
Copy link
Contributor

jquick left a comment

Looking nice @skpaterson !

end

# Instantiate some named classes for ease of use
def gcp_compute_client

This comment has been minimized.

@jquick

jquick Apr 17, 2018

Contributor

if your going to make helper methods can you use the gcp_client for them all? That way the logic is in one spot.

def gcp_iam_client
   gcp_client(Google::Apis::IamV1::IamService)
end

This comment has been minimized.

@skpaterson

skpaterson Apr 18, 2018

Member

Good shout! I'll update that now.

skpaterson added some commits Apr 18, 2018

Updating named clients to use gcp_client to avoid duplication
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Updating to latest berkshelf version to avoid conflicts with google d…
…ependencies.

Signed-off-by: Stuart Paterson <spaterson@chef.io>

@skpaterson skpaterson force-pushed the chef-partners:add-gcp-transport branch from 75539fd to 0a3a587 Apr 18, 2018

Removing unnecessary JSON import.
Signed-off-by: Stuart Paterson <spaterson@chef.io>

skpaterson added some commits Apr 24, 2018

Pinned google-protobuf version to avoid build issue.
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Remove unnecessary space.
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Downgrading berkshelf to help with integration testing.
Signed-off-by: Stuart Paterson <spaterson@chef.io>
@jquick

jquick approved these changes May 14, 2018

Copy link
Contributor

jquick left a comment

Thanks @skpaterson

@jquick jquick merged commit d991228 into inspec:master May 14, 2018

3 checks passed

DCO This commit has a DCO Signed-off-by
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment