Initial import of transport for GCP. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stuart Paterson <spaterson@chef.io>
|
Refs inspec/inspec#2722 |
jquick
reviewed
Apr 17, 2018
| end | ||
|
|
||
| # Instantiate some named classes for ease of use | ||
| def gcp_compute_client |
There was a problem hiding this comment.
if your going to make helper methods can you use the gcp_client for them all? That way the logic is in one spot.
def gcp_iam_client
gcp_client(Google::Apis::IamV1::IamService)
end
There was a problem hiding this comment.
Good shout! I'll update that now.
added 3 commits
April 18, 2018 09:43
Signed-off-by: Stuart Paterson <spaterson@chef.io>
…ependencies. Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Stuart Paterson <spaterson@chef.io>
added 3 commits
April 24, 2018 14:58
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add transport for Google Cloud Platform. Note, this introduces a gem dependency issue with berkshelf.