Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google-api-client version. #531

Merged
merged 4 commits into from
Nov 13, 2019
Merged

Update google-api-client version. #531

merged 4 commits into from
Nov 13, 2019

Conversation

skpaterson
Copy link

Note that knife-google will also be affected by this change - separate PR will be opened there. We should not merge this PR until confirmation the version upgrade is ok.

Signed-off-by: Stuart Paterson spaterson@chef.io

Signed-off-by: Stuart Paterson <spaterson@chef.io>
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Nov 6, 2019

Hello skpaterson! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@skpaterson
Copy link
Author

@skpaterson skpaterson changed the title Uppdate google-api-client version. Update google-api-client version. Nov 7, 2019
@tas50
Copy link
Contributor

tas50 commented Nov 11, 2019

We should really make this a >= constraint TO avoid fallout in the community of consumers

…dback.

Signed-off-by: Stuart Paterson <spaterson@chef.io>
@skpaterson
Copy link
Author

Thanks @tas50 they're updated to a >= constraint. This has been successfully tested against the inspec-gcp resource pack but we should also wait until these are ready:

skpaterson pushed a commit to chef/knife-google that referenced this pull request Nov 13, 2019
Signed-off-by: Stuart Paterson <spaterson@chef.io>
Signed-off-by: Miah Johnson <miah@chia-pet.org>
@codeclimate
Copy link

codeclimate bot commented Nov 13, 2019

Code Climate has analyzed commit 807ec97 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 4

View more on Code Climate.

@miah miah merged commit c5114bc into master Nov 13, 2019
@chef-expeditor chef-expeditor bot deleted the update-google-api-v034 branch November 13, 2019 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants