Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor with_sudo_pty to BaseConnection (no-op) and SshConnection. #554

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

zenspider
Copy link
Contributor

Fixes current red on master.

@zenspider zenspider requested a review from a team as a code owner January 15, 2020 22:55
@ghost ghost requested review from clintoncwolfe and miah January 15, 2020 22:55
@chef-expeditor
Copy link
Contributor

Hello zenspider! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Fixes current red on master.

Signed-off-by: Ryan Davis <zenspider@chef.io>
@codeclimate
Copy link

codeclimate bot commented Jan 15, 2020

Code Climate has analyzed commit 8867db9 and detected 0 issues on this pull request.

View more on Code Climate.

@zenspider zenspider requested a review from tas50 January 15, 2020 23:00
@tas50
Copy link
Contributor

tas50 commented Jan 15, 2020

This seems like a solid step in the right direction

@tas50 tas50 merged commit ab85356 into master Jan 15, 2020
@chef-expeditor chef-expeditor bot deleted the zenspider/ssh/fix branch January 15, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants