Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update activesupport requirement from ~> 5.2.3 to >= 5.2.3, < 6.1.0 #589

Merged

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on activesupport to permit the latest version.

Release notes

Sourced from activesupport's releases.

5.2.4.2

Active Support

  • No changes.

Active Model

  • No changes.

Active Record

  • No changes.

Action View

  • Fix possible XSS vector in escape_javascript helper

    CVE-2020-5267

    Aaron Patterson

Action Pack

  • No changes.

Active Job

  • No changes.

Action Mailer

  • No changes.

Action Cable

  • No changes.
... (truncated)
Commits
  • 4dcc543 update version
  • ac30e38 Preparing for 5.2.4.1 release
  • 8bec77c Preparing for 5.2.4 release
  • 9e2a341 Preparing for 5.2.4.rc1 release
  • fbcb47b dup instead of @+ since we still support Ruby 2.2
  • ed81031 Merge pull request #37303 from eregon/follow-frozen-symbol-to_s
  • 17c4240 Merge pull request #35121 from utilum/warning_tried_to_create_proc_without_block
  • 2e5a6b3 Merge pull request #36753 from cmrd-senya/36752-make-rails-logger-fiber-safe
  • 371e854 Merge pull request #36470 from lucasprag/activesupport/missing-require-digest
  • 13de946 Backport changes for Buildkite builds
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Updates the requirements on [activesupport](https://github.com/rails/rails) to permit the latest version.
- [Release notes](https://github.com/rails/rails/releases)
- [Changelog](https://github.com/rails/rails/blob/v6.0.3/activesupport/CHANGELOG.md)
- [Commits](rails/rails@v5.2.3...v5.2.4.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot requested a review from a team as a code owner May 13, 2020 19:27
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label May 13, 2020
@chef-expeditor
Copy link
Contributor

Hello dependabot-preview[bot]! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
@Schwad
Copy link

Schwad commented May 18, 2020

Something to think about - latest ActiveSupport major version does not support ruby 2.4 at all. So this PR fails. I updated the PR to give us the latest 5.x ActiveSupport and protect us from 6.x ActiveSupport in the future.

Ruby 2.4 is just recent enough (end of 2016 initial release) that it wouldn't shock me if someone was still stuck to it.

However, we'll need to remember that if we want an ActiveSupport >6 feature, we won't be able to get it and support 2.4. Don't know if that warrants an additional issue.

@Schwad
Copy link

Schwad commented May 18, 2020

Gem::RuntimeRequirementNotMetError: activesupport requires Ruby version >=
--
  | 2.5.0. The current ruby version is 2.4.10.364.
  | An error occurred while installing activesupport (6.0.3), and
  | Bundler cannot continue.
  | Make sure that `gem install activesupport -v '6.0.3' --source
  | 'https://rubygems.org/'` succeeds before bundling.

@dependabot-preview
Copy link
Contributor Author

A newer version of activesupport exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Schwad Schwad merged commit d87c727 into master May 19, 2020
@chef-expeditor chef-expeditor bot deleted the dependabot/bundler/activesupport-gte-5.2.3-and-lt-6.1.0 branch May 19, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants