Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google gem versions for train #635

Merged
merged 1 commit into from
Sep 9, 2020

Conversation

lhasadreams
Copy link

@lhasadreams lhasadreams commented Sep 8, 2020

Description

Google::Apis::ComputeV1::ComputeService has a new method:
list_network_peering_routes
The gem versions being used for the API and Auth need updating to get this new capability.

Related Issue

A Chef customer needs this update to get one of their GCP InSpec controls to function.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.

@lhasadreams lhasadreams requested a review from a team as a code owner September 8, 2020 13:57
@chef-expeditor
Copy link
Contributor

chef-expeditor bot commented Sep 8, 2020

Hello lhasadreams! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Signed-off-by: lhasadreams <adrian@chef.io>
@Schwad
Copy link

Schwad commented Sep 9, 2020

@lhasadreams looks good to me- since we have an approval from @inspec/foundation-team-reviewers I'm happy to send this forward and it'll be in the next release

@Schwad Schwad merged commit 48f9375 into inspec:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants