-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete rewrite of windows version detection #70
Conversation
Might consider And querying |
Then you may just need one call |
@mwrock Great Idea. Is that working on CLI as well? We do not have WinRM available all the time. I try to find a solution that is very minimal and works remote and locally. It should have no specific dependency on PowerShell or any scripting. |
Oh I thought this was all remote. Wmic would be the cli equivalent |
41de364
to
f574f71
Compare
Thanks @mwrock for this great idea. |
d739ba9
to
9e0d7e0
Compare
9e0d7e0
to
ed4a51f
Compare
Awesome improvement, and much simpler this way. Love the tests too @chris-rock 👍 |
complete rewrite of windows version detection
✋ |
The new Windows version detection is not based on Powershell anymore, it uses two core commands:
ver
is a command-line tool since MSDOS that outputs the version of the Operating Systemsysteminfo
was introduced in Windows XP Professional and outputs more system detailswmic os get * /format:list
to retrieve the details of the operating systemUnfortunately we cannot rely on
ver
only, since build numbers and version are sometimes the same between Windows Client and Server. Therefore we cannot use this alone to distinguish between both operating systems.