Fix SyntaxError: Illegal return statement #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 16, 2019
There was a problem hiding this comment.
See inspect-js/is-set#4 (review)
This is not a syntax error whatsoever; this is a node module and top level return is allowed in it.
What bundler are you using that breaks on valid node modules?
Jessidhia
suggested changes
Dec 17, 2019
| @@ -20,7 +19,6 @@ if (!$mapHas) { | |||
| // `Map` does not have a `has` method | |||
| return false; | |||
| }; | |||
| return; | |||
There was a problem hiding this comment.
Even if you were to get rid of these returns, this is not it; you need to convert the rest of the file into else bodies.
Closes inspect-js#5. Closes inspect-js#4. Closes inspect-js#3. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to inspect-js/is-set#4, inspect-js/is-set#5 Addresses storybookjs/storybook#9154.
ljharb
force-pushed
the
fix-suntaxerror
branch
from
6234d0d
to
a0a0d4a
Compare
ljharb
added a commit
to gitim/is-set
that referenced
this pull request
Dec 17, 2019
Closes inspect-js#5. Closes inspect-js#4. Closes inspect-js#3. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to inspect-js/is-map#3, inspect-js/is-map#4, inspect-js/is-map#5 Addresses storybookjs/storybook#9154.
ljharb
added a commit
to inspect-js/is-weakmap
that referenced
this pull request
Dec 18, 2019
Closes inspect-js/node-deep-equal#79. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to: - inspect-js/is-map#5 - inspect-js/is-map#4 - inspect-js/is-map#3 - inspect-js/is-set#5 - inspect-js/is-set#4 - storybookjs/storybook#9154.
ljharb
added a commit
to inspect-js/is-weakset
that referenced
this pull request
Dec 18, 2019
Closes inspect-js/node-deep-equal#79. Closes inspect-js/node-deep-equal#78. Closes es-shims/Promise.allSettled#7. Closes airbnb/js-shims#12. Relates to: - inspect-js/is-map#5 - inspect-js/is-map#4 - inspect-js/is-map#3 - inspect-js/is-set#5 - inspect-js/is-set#4 - storybookjs/storybook#9154.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faced with SyntaxError in this package, because some package in my project depend from this package.