pkg/oci: Do not trim repository prefix if default.

[eiffel-fl]

Otherwise, it impedes image removing by only untagging them.

Fixes: bd5578b ("oci: Use default registry for Inspektor Gadget")

[mqasimsarfraz]

Otherwise, it impedes image removing by only untagging them.

It was our intent to have similar UX as docker. Can't we just append the prefix to image remove if needed or the issue is coming from oras-go?

[mauriciovasquezbernal]

Otherwise, it impedes image removing by only untagging them.

It was our intent to have similar UX as docker. Can't we just append the prefix to image remove if needed or the issue is coming from oras-go?

I also see these two options:

• Make listGadgetImages return the image with the full url, and trim the prefix in ListGadgetImages
• Add a trimDefaultPrefix parameter to listGadgetImages, it'll be true when called from ListGadgetImages, but false when called from DeleteGadgetImage

[eiffel-fl]

Otherwise, it impedes image removing by only untagging them.

It was our intent to have similar UX as docker. Can't we just append the prefix to image remove if needed or the issue is coming from oras-go?

No problem on oras-go side but this change broke image removal.
I opened this PR to discuss this.

I also see these two options:

* Make `listGadgetImages` return the image with the full url, and trim the prefix in `ListGadgetImages`

This is also my opinion, as we just want to hide the default registry to user.
I will tweak to code to export the variables used for the default registry and trim it here.

* Add a `trimDefaultPrefix` parameter to `listGadgetImages`, it'll be true when called from `ListGadgetImages`, but false when called from `DeleteGadgetImage`

[mauriciovasquezbernal]

Actually my proposal was to make this on ListGadgetImages. I don't think we should expose the default registry details outside the pkg/oci package.

[eiffel-fl]

Actually my proposal was to make this on ListGadgetImages. I don't think we should expose the default registry details outside the pkg/oci package.

OK, but in this case we need a loop here while using the extractor would avoid this.

[mauriciovasquezbernal]

That's why I proposed the second option:

Add a trimDefaultPrefix parameter to listGadgetImages, it'll be true when called from ListGadgetImages, but false when called from DeleteGadgetImage

[eiffel-fl]

That's why I proposed the second option:

Add a trimDefaultPrefix parameter to listGadgetImages, it'll be true when called from ListGadgetImages, but false when called from DeleteGadgetImage

I find this even more hacky.
Can we merge it? It addresses the underlying problem and I would like to move forward with #2402.

[mauriciovasquezbernal]

As I mentioned before, I think we shouldn't expose the default prefix outside of this module. It'll fix this immediate issue, but then all users of this will have to be aware of the default domain, so I prefer to keep the logic only on this module for now.

[eiffel-fl]

Damn, I forgot to push the new version using only local variables.

[mauriciovasquezbernal]

LGTM. Thanks!

[eiffel-fl]

Thank you for the review!