pkg/oci: Use garbage collecting to delete whole image. #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eiffel-fl
requested review from
alban and
mauriciovasquezbernal
as code owners
eiffel-fl
force-pushed
the
francis/fix-rmi
branch
2 times, most recently
from
cb66e86
to
51ae18f
Compare
eiffel-fl
force-pushed
the
francis/fix-rmi
branch
from
51ae18f
to
b361084
Compare
mauriciovasquezbernal
approved these changes
Jan 29, 2024
eiffel-fl
force-pushed
the
francis/rmi-upstream
branch
from
2325239
to
dd85e43
Compare
Upstream recently added code to garbage collect manifests [1]. By using this, we can remove deleteTree(). Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com> [1]: oras-project/oras-go@64fedf45bfd3
eiffel-fl
force-pushed
the
francis/rmi-upstream
branch
from
dd85e43
to
e08674c
Compare
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream recently added code to garbage collect manifests [1]. By using this, we can remove deleteTree().
Signed-off-by: Francis Laniel flaniel@linux.microsoft.com
[1]: oras-project/oras-go@64fedf45bfd3