Modified m_timedbans to behave more like setting mode +b manually. #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now accepts extbans. If one enters something not an extban, or valid banmask, it'll add "!*@*", making it a nick-ban instead of borking.
|
You have to be careful adding stuff to the end of banmaks, awhile ago there was a glitch where you could set a ban that was @******{repeat until end of line}, then inspircd would add *! to the front of the ban, making the ban longer than the accepted line length, resulting in an unremovable ban. I think you may have made it possible to do this again. |
|
Welp, you're right. This clearly wasn't thought through well enough by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now accepts extbans. If one enters something not an extban, or valid banmask, it'll add "!@", making it a nick-ban instead of borking.
Fixes #377