Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: test suite modules, f-strings, setup requires fix #9

Merged
merged 3 commits into from
May 8, 2018

Conversation

szymonlopaciuk
Copy link
Contributor

  • refactor errors to use python 3 f-strings
  • remove overlap between tests_require and install_requires in setup.py
  • make test suites modules (by adding __init__.py to each) in order to allow the same file names in different suites

Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 54

  • 5 of 7 (71.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.388%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inspire_mitmproxy/errors.py 5 7 71.43%
Totals Coverage Status
Change from base Build 53: 0.0%
Covered Lines: 191
Relevant Lines: 209

💛 - Coveralls

@szymonlopaciuk szymonlopaciuk mentioned this pull request May 8, 2018
@david-caro david-caro merged commit bb41433 into inspirehep:master May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants