Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

orcid: make the OAuth token last longer #2265

Closed
jacquerie opened this issue Apr 21, 2017 · 5 comments
Closed

orcid: make the OAuth token last longer #2265

jacquerie opened this issue Apr 21, 2017 · 5 comments
Assignees
@jmartinm
Labels
Type: Bug

Comments

@jacquerie
Copy link
Contributor

Because it annoys me I have to type my password so frequently :P
@jacquerie
Copy link
Contributor Author

Actually this has nothing to do with OAuth, but it's a core Flask setting: https://stackoverflow.com/a/11785722/374865.

@jmartinm
Copy link
Contributor

jmartinm commented Jun 8, 2017

I think we are just missing this config setting - https://github.com/inveniosoftware/invenio-oauthclient/blob/master/invenio_oauthclient/config.py#L85

@jmartinm jmartinm self-assigned this Jun 9, 2017
@jmartinm
Copy link
Contributor

jmartinm commented Jun 9, 2017

Will test it now in QA.

@jmartinm
Copy link
Contributor

jmartinm commented Jun 9, 2017

It will not work if I don't fix inveniosoftware/invenio-oauthclient#133 first...

@jacquerie
Copy link
Contributor Author

Whoops! Well, we could meanwhile hack around it with the mechanism I suggested...

jmartinm added a commit to jmartinm/inspire-next that referenced this issue Jul 20, 2017
@jmartinm
config: add remember=True to ORCID login
954907b 
* Effect of this flag is to set an extra cookie that will increase the
  session validity. (closes inspirehep#2265)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
@jmartinm jmartinm mentioned this issue Jul 20, 2017
Closed
8 tasks
jmartinm added a commit to jmartinm/inspire-next that referenced this issue Jul 20, 2017
@jmartinm
config: add remember=True to ORCID login
d0c7936 
* Effect of this flag is to set an extra cookie that will increase the
  session validity. (closes inspirehep#2265)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
jmartinm added a commit to jmartinm/inspire-next that referenced this issue Jul 20, 2017
@jmartinm
config: add remember=True to ORCID login
171e5b7 
* Effect of this flag is to set an extra cookie that will increase the
  session validity. (closes inspirehep#2265)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
@ghost ghost removed the Status: WIP label Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinm jmartinm

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: add remember=True to ORCID login jmartinm/inspire-next
2 participants
@jacquerie @jmartinm