Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remember config is not used #133

Closed
jmartinm opened this issue Jun 9, 2017 · 0 comments · Fixed by #134
Closed

remember config is not used #133

jmartinm opened this issue Jun 9, 2017 · 0 comments · Fixed by #134
Assignees
@jmartinm
Labels
Status: in review

Comments

@jmartinm
Copy link
Member

jmartinm commented Jun 9, 2017

A remote app cannot set remember=True since the parameter is ignored (

invenio-oauthclient/invenio_oauthclient/utils.py

Line 89 in 90083a5

remember=False):
)

The parameter should be passed to login_user instead.
@jmartinm jmartinm self-assigned this Jun 9, 2017
@jmartinm jmartinm mentioned this issue Jun 9, 2017
Closed
jmartinm added a commit to jmartinm/invenio-oauthclient that referenced this issue Jun 9, 2017
@jmartinm
utils: pass remember parameter to login_user
3c09e12 
* Allows oauth applications to set the remember parameter to
  avoid session to expire. (closes inveniosoftware#133)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
@jmartinm jmartinm mentioned this issue Jun 9, 2017
Merged
lnielsen pushed a commit that referenced this issue Jun 14, 2017
@jmartinm @lnielsen
utils: pass remember parameter to login_user
1753ecb 
* Allows oauth applications to set the remember parameter to
  avoid session to expire. (closes #133)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
oguzdemirbasci pushed a commit to oguzdemirbasci/invenio-oauthclient that referenced this issue Jan 8, 2021
@jmartinm @oguzdemirbasci
utils: pass remember parameter to login_user
0ca77a0 
* Allows oauth applications to set the remember parameter to
  avoid session to expire. (closes inveniosoftware#133)

Signed-off-by: Javier Martin Montull <javier.martin.montull@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmartinm jmartinm

Labels
Status: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

utils: pass remember parameter to login_user jmartinm/invenio-oauthclient
1 participant
@jmartinm