Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect current index. #20

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

callumtilbury
Copy link
Contributor

Coming from discussions in #16. I think we should spend more time on that PR, deciding how we want the read API to look.

But in the interim, there is definitely a bug in the current index of the fbx buffer returned by a vault read—thanks @EdanToledo! Let's fix that now :)

Copy link
Contributor

@EdanToledo EdanToledo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@callumtilbury callumtilbury merged commit 62abedd into main Feb 28, 2024
2 checks passed
@callumtilbury callumtilbury deleted the fix/incorrect-current-index branch February 28, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants