feat: Improving the flexibility of reading vaults #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdanToledo
reviewed
Feb 20, 2024
| ), | ||
| ) | ||
| read_buffer_is_full = self.vault_index >= self._buffer_time_axis_len | ||
| read_buffer_index = self.vault_index |
There was a problem hiding this comment.
Does this make sense in every case? If the vault buffer is larger than the buffer time axis then a full buffer is returned, wouldn't the read buffer index then need to be set to zero?
EdanToledo
reviewed
Feb 20, 2024
| read_interval = (self.vault_index - timesteps, self.vault_index) | ||
| # If timesteps are provided, we always return a full buffer state | ||
| read_buffer_is_full = True | ||
| read_buffer_index = timesteps |
EdanToledo
reviewed
Feb 20, 2024
| assert ( | ||
| percentiles[0] < percentiles[1] | ||
| ), "Percentiles must be in ascending order." | ||
| read_interval = ( | ||
| int(self.vault_index * (percentiles[0] / 100)), | ||
| int(self.vault_index * (percentiles[1] / 100)), | ||
| ) | ||
| # If percentiles are provided, we always return a full buffer state | ||
| read_buffer_is_full = True | ||
| read_buffer_index = read_interval[1] - read_interval[0] |
There was a problem hiding this comment.
potentially here as well
|
Going to revisit the reading of vaults at some point, but we can restart the discussion when that happens—with some careful thought. For now, I am closing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first suggestion for #15. We could make things more explicit (handling everything a user may possibly want), but I also want to keep the code fairly streamlined & straightforward. Open to discussion.
timestepsorpercentilesare requested, return a "full" buffer, with the appropriate data.vault_index<fbx_buffer_state_size, make the returned buffer the original buffer size, withis_full = False; otherwise, return a full buffer.