reject non-hex strings for claim_script

instagibbs · Sep 25, 2018 · d084d36 · d084d36
1 parent af19891
commit d084d36
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/wallet/rpcwallet.cpp b/src/wallet/rpcwallet.cpp
@@ -3586,6 +3586,10 @@ static UniValue createrawpegin(const JSONRPCRequest& request, T_tx_ref& txBTCRef
     CScript witnessProgScript;
     unsigned int nOut = txBTC.vout.size();
     if (request.params.size() > 2) {
+        std::string claim_script = ParseHex(request.params[2].get_str());
+        if (!IsHex(claim_script)) {
+            throw JSONRPCError(RPC_INVALID_PARAMETER, "Given claim_script is not hex.");
+        }
         // If given manually, no need for it to be a witness script
         std::vector<unsigned char> witnessBytes(ParseHex(request.params[2].get_str()));
         witnessProgScript = CScript(witnessBytes.begin(), witnessBytes.end());