Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get list of blocked users #593

Closed
wants to merge 2 commits into from
Closed

Get list of blocked users #593

wants to merge 2 commits into from

Conversation

unldenis
Copy link
Contributor

@unldenis unldenis commented Jun 10, 2021

Already tested and it works.
#570

Copy link
Collaborator

@jvogit jvogit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! The request LGTM just change the naming to fit convention and I'll pull it in.

import com.github.instagram4j.instagram4j.requests.IGGetRequest;
import com.github.instagram4j.instagram4j.responses.users.UsersBlockedResponse;

public class UsersBlockedRequest extends IGGetRequest<UsersBlockedResponse> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi sorry to nitpick but naming convention for request should follow similarly to the request path + Request appended at the end.

So this would be UsersBlockedListRequest (patrh is /users/blocked_list/

import lombok.Data;

@Data
public class UsersBlockedResponse extends IGResponse {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. Should match the request but has Response at the end instead.

@unldenis unldenis requested a review from jvogit June 13, 2021 12:30
@unldenis
Copy link
Contributor Author

unldenis commented Jun 13, 2021

I create a new pull request for configuration issues. #596

@unldenis unldenis closed this Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants