Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mentions include email addresses #1029

Closed
kallewesterling opened this issue Feb 17, 2021 · 0 comments · Fixed by #1167
Closed

Mentions include email addresses #1029

kallewesterling opened this issue Feb 17, 2021 · 0 comments · Fixed by #1167
Labels
bug Bug good first issue Easy to tackle, good starting point for new Instaloader contributors

Comments

@kallewesterling
Copy link
Contributor

Describe the bug
The Post.mentions attribute (list) includes potential email addresses.

To Reproduce
I used Instaloader as Python module.

Expected behavior
Say that someone's email i_am_me@outlook.com appears in the caption. Instaloader will currently list @outlook.com as a mention, which is obviously wrong.
@kallewesterling kallewesterling added the bug Bug label Feb 17, 2021
@github-actions github-actions bot added the stale Issue is inactive for a long time label May 19, 2021
@aandergr aandergr removed the stale Issue is inactive for a long time label May 20, 2021
@instaloader instaloader deleted a comment from github-actions bot May 20, 2021
@aandergr aandergr added the good first issue Easy to tackle, good starting point for new Instaloader contributors label May 20, 2021
kallewesterling added a commit to kallewesterling/instaloader that referenced this issue Jun 3, 2021
@kallewesterling
Mentions include email addresses
c7d5bff 
Fixes instaloader#1029
@kallewesterling kallewesterling mentioned this issue Jun 3, 2021
Merged
aandergr pushed a commit that referenced this issue Jun 6, 2021
@kallewesterling
Fix Post.mentions including email addresses (#1167)
9ffdf25 
Earlier, if someone had an email address in the caption, those were provided as mentions in the Post.mentions attribute. With this update to the regular expression, email addresses are no longer ingested.

Fixes #1029.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Bug good first issue Easy to tackle, good starting point for new Instaloader contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mentions include email addresses Fixes #1029 kallewesterling/instaloader
2 participants
@kallewesterling @aandergr