Mentions include email addresses Fixes #1029 #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandergr
reviewed
Jun 4, 2021
Co-authored-by: Alexander Graf <17130992+aandergr@users.noreply.github.com>
|
I had no idea, but that seems like a reasonable edit then! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1029.
Earlier, if someone had an email address in the caption, those were provided as mentions in the
Post.mentionsattribute. With this update to the regular expression, email addresses are no longer ingested.This change is complete, and no need for updates in documentation as the attribute should work as before. Ready to be merged.