Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API webvitalsInCustomEvent to track webvitals in custom event. #125

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

lisr
Copy link
Contributor

@lisr lisr commented Aug 29, 2023

WHY:
In some case, the webvitals metrics arrive too late after the PageLoad beacon, therefore user cannot depends on these metrics to create Alerts.

WHAT:
Add a new command webvitalsInCustomEvent (false by default), when it's enabled, webvitals will be reported in extra custom events when it's available.

The naming conversion for these metrics are instana-webvitals-CLS, instana-webvitals-LCP, instana-webvitals-FID etc.

the web-vitals was also upgraded to 1.1.2 from 1.1.1.

@lisr lisr requested a review from a team August 29, 2023 04:45
Copy link
Contributor

@xiaoluxl xiaoluxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisr lisr merged commit 118b99e into main Aug 29, 2023
1 check passed
@lisr lisr deleted the large_webvitals branch August 29, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants