Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save raw webvital value to meta #126

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Save raw webvital value to meta #126

merged 1 commit into from
Aug 29, 2023

Conversation

lisr
Copy link
Contributor

@lisr lisr commented Aug 29, 2023

A followup fix to #125,
when webvitalsInCustomEvent is enabled, this will also add raw value into meta data.

@lisr lisr requested a review from a team August 29, 2023 08:43
Copy link
Contributor

@xiaoluxl xiaoluxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lisr lisr merged commit 8e15afb into main Aug 29, 2023
1 check failed
@lisr lisr deleted the large_webvitals branch August 29, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants