Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve XHR so that it cooperates better with other instrumentations #34

Merged
merged 3 commits into from
May 7, 2019

Conversation

bripkens
Copy link
Contributor

@bripkens bripkens commented May 2, 2019

No description provided.

@bripkens bripkens added the WIP label May 2, 2019
@bripkens bripkens force-pushed the improve-xhr-instrumentation branch 3 times, most recently from b345e33 to 9c64887 Compare May 3, 2019 11:59
@bripkens bripkens force-pushed the improve-xhr-instrumentation branch from 9c64887 to 6e02baa Compare May 3, 2019 14:20
@basti1302 basti1302 self-requested a review May 3, 2019 14:34
@basti1302 basti1302 self-assigned this May 3, 2019
Copy link
Contributor

@basti1302 basti1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some tiny nits.

lib/vars.js Outdated Show resolved Hide resolved
lib/vars.js Outdated Show resolved Hide resolved
lib/hooks/XMLHttpRequest.js Show resolved Hide resolved
lib/hooks/XMLHttpRequest.js Outdated Show resolved Hide resolved
lib/transmission/formEncoded.js Show resolved Hide resolved
@bripkens bripkens force-pushed the improve-xhr-instrumentation branch from ae59694 to ed176ce Compare May 6, 2019 19:24
@bripkens bripkens merged commit 60db95a into master May 7, 2019
@bripkens bripkens deleted the improve-xhr-instrumentation branch May 7, 2019 05:10
instanacd pushed a commit that referenced this pull request Mar 6, 2024
* Update CHANGELOG.md and package.json for v1.6.4

* Modified CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants