Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradle wrapper version #538

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

EvaristeGalois11
Copy link
Contributor

Hi, currently the project doesn't compile with a java version greater than 17 even if https://www.instancio.org/building/ states otherwise.

This is because the gradle wrapper used in the annotation-processor-with-gradle module supports a maximum version of 17. You can see the compatibility grid here https://docs.gradle.org/current/userguide/compatibility.html

I bumped the gradle wrapper version to the latest major version. This major version should receive java 20 support soon gradle/gradle#23488

With this simple bump the module compile without problems with my java 19 :D

Bye!

@armandino
Copy link
Member

@EvaristeGalois11 Thanks very much for reporting this and submitting a fix! I don't think I've tried building with 19 yet.

I cannot run Github workflows because currently all PRs from forks fail due to not having access to the sonar token. I'll have to look into that at some point... However, I tried your branch locally and it builds successfully for me, so I will go ahead with the merge.

@armandino armandino merged commit 113aff7 into instancio:main Apr 1, 2023
@armandino armandino added type: tests Create additional tests type: build Issue related to build, dependencies, or CI labels Apr 1, 2023
@EvaristeGalois11 EvaristeGalois11 deleted the gradle-wrapper-upgrade branch April 1, 2023 23:12
@EvaristeGalois11
Copy link
Contributor Author

@EvaristeGalois11 Thanks very much for reporting this and submitting a fix! I don't think I've tried building with 19 yet.

I cannot run Github workflows because currently all PRs from forks fail due to not having access to the sonar token. I'll have to look into that at some point... However, I tried your branch locally and it builds successfully for me, so I will go ahead with the merge.

Thank you for accepting the PR!

I admit i don't know much about github workflows and such because i have always submitted PR never accepted them lol

But i'm happy to help if you need some extra hands :D

@armandino
Copy link
Member

@EvaristeGalois11 I believe currently it's not supported:

https://community.sonarsource.com/t/code-analysis-on-pull-request-from-forked-repository-with-github-actions/43986/6

From what I remember when I looked into this a few months back is that there was a workaround but it had some drawbacks. Can't recall the details though. In any case, if you know of a good approach, a PR would be welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: build Issue related to build, dependencies, or CI type: tests Create additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants