Ft/owncloud #41
Ft/owncloud #41
Conversation
… updated for python 3.5 before this becomes usable.
…pyocclient 0.3 comes out
This updates the owncloud feature branch in order to be able to easily merge it. Since pyocclient 0.4 was released recently, we can finally support uploading to owncloud.
|
pyocclient 0.4 was released recently, so we could merge owncloud support now. Reviews would be appreciated! |
There was a problem hiding this comment.
Works fine now. Could be improved by sharing a direct file link instead of the ownCloud link since the ownCloud link redirects to the ownCloud UI with the embedded snapshot.
Just as a reminder: We have to change the password logic if we merge the keyring integration first.
|
Updated the owncloud implementation to use the kvstore now. I also implemented some URL transformation similar to what we have for dropbox. |
src/storage/owncloud.py
Outdated
|
|
||
| def _transform_url(url: str) -> str: |
There was a problem hiding this comment.
_transform_url doesn't work properly. The transformed URL only shows a small thumbnail when opened and not the actual image.
There was a problem hiding this comment.
OwnCloud does not support direct links to files because of concerns about cross site scripting. So for images, transforming the URL would be a solution. We would need the dimensions of the image though. Looking at multimedia support further complicating things, I'm starting to think we should just leave the link as is (ditch the _transform_url function). That's how it's supposed to be shared anyways. What do you think?
This reverts commit 7ed7147.
|
Reverted the direct URL thing for now, we could iterate on this in the future. |
Maybe we should merge this before we change the storage providers. It will only work with pyocclient 0.3, which is not finished yet, but I think it would be beneficial to carry this along for the time being.Closes #6 if we do so.
Any thoughts?Edit: Just thought about this. As you can see, we're behind the latest changes with owncloud support again. If we carried it along, it would always be up to date and it will eventually work. We'll need to think about therequirements.txtthough, as 0.3 is not out yet. I don't know if that's a problem.Edit 2: See post below.