Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors from temporarily disabled eslint rules #126

Closed
9 tasks
DanielSchaffer opened this issue Jan 27, 2020 · 1 comment
Closed
9 tasks

Fix errors from temporarily disabled eslint rules #126

DanielSchaffer opened this issue Jan 27, 2020 · 1 comment
Assignees
@DanielSchaffer
Labels
good first issue Good for newcomers

Comments

@DanielSchaffer
Copy link
Contributor

DanielSchaffer commented Jan 27, 2020 •
edited
Loading

Several rules from eslint-plugin-hyperview were disabled when upgrading the plugin in #125

Re-enable the following rules in .eslintrc and fix the errors:

  • import/no-cycle
  • lines-between-class-members
  • no-else-return
  • no-restricted-globals
  • prefer-destructuring
  • react/destructuring-assignment
  • react/jsx-sort-props
  • react/no-access-state-in-setstate
  • sort-keys
@DanielSchaffer DanielSchaffer added the good first issue Good for newcomers label Jan 27, 2020
@DanielSchaffer DanielSchaffer mentioned this issue Jan 28, 2020
Closed
@DanielSchaffer DanielSchaffer self-assigned this Jan 28, 2020
@flochtililoch
Copy link
Collaborator

Resolved in #215

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielSchaffer DanielSchaffer

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flochtililoch @DanielSchaffer