Chore: remove duplicate prettier configs #125
Conversation
|
Looks like the Netlify build is failing due to it attempting to install |
DanielSchaffer
force-pushed
the
daniel/remove-duplicate-prettier-configs
branch
from
9af118d
to
651b00b
Compare
…work - initially disable newly breaking rules - use NodeJS 10.18.1 (latest 10.x - LTS/12.x has issues with the fsevents dependency) - add nvmrc with matching version to circleci build image closes #37
DanielSchaffer
force-pushed
the
daniel/remove-duplicate-prettier-configs
branch
from
651b00b
to
8a5f9f4
Compare
| "eslint-config-prettier": "3.3.0", | ||
| "eslint-plugin-instawork": "0.0.2", | ||
| "eslint-plugin-prettier": "3.0.0", | ||
| "eslint": "5.16.0", |
There was a problem hiding this comment.
Are there any breaking changes in this eslint upgrade that may require changes in the custom rules in eslint-plugin-instawork?
There was a problem hiding this comment.
Not that I'm aware of - 5.16.0 is the same version used by eslint-plugin-instawork
| "react/destructuring-assignment": "off", | ||
| "react/jsx-sort-props": "off", | ||
| "react/no-access-state-in-setstate": "off", | ||
| "sort-keys": "off" |
There was a problem hiding this comment.
We follow a convention of sorting keys alphabetically. This seems to bypass that if I'm not mistaken?
There was a problem hiding this comment.
Correct, though it is intended to be temporary. Upgrading to eslint-plugin-instawork@0.4.0 resulted in 200+ new linting errors. I decided to leave fixing the errors to different PR - see #126 so this one could be kept as small as possible.
| "no-restricted-globals": "off", | ||
| "prefer-destructuring": "off", | ||
| "react/destructuring-assignment": "off", | ||
| "react/jsx-sort-props": "off", |
There was a problem hiding this comment.
We follow a convention of sorting props alphabetically. This seems to bypass that if I'm not mistaken?
There was a problem hiding this comment.
Correct, though it is intended to be temporary. Upgrading to eslint-plugin-instawork@0.4.0 resulted in 200+ new linting errors. I decided to leave fixing the errors to different PR - see #126 so this one could be kept as small as possible.
| "import/no-cycle": "off", | ||
| "lines-between-class-members": "off", | ||
| "no-else-return": "off", | ||
| "no-restricted-globals": "off", | ||
| "prefer-destructuring": "off", | ||
| "react/destructuring-assignment": "off", | ||
| "react/jsx-sort-props": "off", | ||
| "react/no-access-state-in-setstate": "off", | ||
| "sort-keys": "off" |
There was a problem hiding this comment.
I think some of them should be added to eslint-plugin-instawork instead of hyperview repo individually. Could you also consult @flochtililoch for these changes? Some of them were intentionally added in eslint-plugin-instawork.
There was a problem hiding this comment.
See my other comments - these are intended to be temporary.
DanielSchaffer
force-pushed
the
daniel/remove-duplicate-prettier-configs
branch
from
5345ad0
to
a404e4d
Compare
|
Thanks for your first contribution to Hyperview repo, @DanielSchaffer! |
|
Some of the changes here overlap with #215, closing this for now |
Updates linting configurations, dependencies, and runtime versions to allow using latest
eslint-plugin-prettierbabel-eslint,eslint,prettier,pretty-quickto match versions used byeslint-plugin-prettier@babel/core, required byeslint10.18.1:@babel/coredoes not support the existing build version (8.7), and the 8.x line is EOL as of 12/31/2019.10.18.1is the most up to date from 10.x, which is still in extended maintenance