-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more examples to puns/qna.yaml #119
Conversation
Signed-off-by: Boulama AL HADJI <121521903+bh1000@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing/replacing the existing seed_examples
add your's to the bottom of the list of existing ones
Coming back from the dentist, a girl and her mother discuss: | ||
|
||
Well I don't know, it stayed in the dentist's office. | ||
quesiton: Tell a pun about a dentist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quesiton:
<-- the i
and t
got switched
question:
@@ -1,52 +1,54 @@ | |||
created_by: mairin | |||
created_by: bh1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not remove the original author, maybe we can add a comment for authors who amend existing files
i.e. you could add a new field:
created_by: mairin
co_authors:
- bh1000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjhargrave @lehors @markstur -- what is your take on co-authors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some discussion on this over in https://github.com/instruct-lab/cli/issues/220
Thank you for taking the time to submit to instruct-lab! I know this wasn't easy and could have been quite time-consuming. Unfortunately, our team has decided that submissions for jokes or poems (skills and knowledge) are no longer supported or approved. We received so many at the beginning, and with jokes being "in the eye of the beholder" and puns requiring nuance for native English speakers, we realized we were possibly unconsciously biasing our model. We have discovered that working with both topics has its own challenges, and if we want something generalized, finding consensus was unsuccessful. We have updated the avoid topics to reflect this, and if you have more questions, don't hesitate to comment on this PR. We may revisit this in the future, but we are looking for unique skills or new knowledge for the model; poems and jokes, unfortunately, don't fit this plan. Thank you again for taking this time, and we are looking forward to your next PR to the instruct-lab project! |
Thank you for your feedback, I do understand your point. |
If your PR is related to a contribution to the taxonomy, please, fill
out the following questionaire. If not, replace this whole text and the
following questionaire with whatever information is applicable to your PR.
Describe the contribution to the taxonomy
Input given at the prompt
Response that was received
Response that is now received instead
Contribution checklist
lab generate
-> nolab generate
does not produce any warnings or errors to -> to be confirmedqna.yaml
file was linted -> yes