Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the Beta environment, sending properties wrapped in brackets to certain API calls results in no visible error but results in no value saved #2334

Open
MakotoTheKnight opened this issue Mar 22, 2024 · 2 comments

Comments

@MakotoTheKnight
Copy link

MakotoTheKnight commented Mar 22, 2024

Summary: We have been leveraging the Update Course Settings API PUT call to Canvas to set the announcements for courses. With some changes to the environment, this no longer seems to work. In Beta, this fails and does not return true when called. In test and production, this works as expected.

Steps to reproduce:

  1. Pick any course you have the permission to update (e.g. api/v1/courses/<course>/settings)
  2. Pass in as form parameters the following (brackets are important):
[show_announcements_on_home_page] = true
  1. Observe response from Canvas.

Expected behavior:

show_announcements_on_home_page returns true

Actual behavior:

In beta only, show_announcements_on_home_page returns false

Additional notes:

We're sort of stuck with the KSU Canvas API for the time being, and on inspection this behavior has been present in this library for about four years now.

@tarunsankhla
Copy link

can I take this issue ?

I am new to the code base but I will figure things out to resolve the issue

@MakotoTheKnight
Copy link
Author

can I take this issue ?

I am new to the code base but I will figure things out to resolve the issue

@tarunsankhla We've heard from Instructure that this will not be fixed on their end, and we don't disagree with the assessment (honestly, the fact that it worked like this was surprising to begin with). We're pivoting instead to forking the KSU library to fix the issue ourselves for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants