Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize CCV for development #49

Merged
merged 1 commit into from Dec 3, 2018
Merged

Dockerize CCV for development #49

merged 1 commit into from Dec 3, 2018

Conversation

dnehring
Copy link
Contributor

fixes CM-604

test plan:
dc build is successful
dc up allows hitting viewer.ccv.docker

@CLAassistant
Copy link

CLAassistant commented Nov 30, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cguanzon cguanzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dc build
dc run --rm ccv npm install
dc up

when i visit viewer.ccv.docker i get

TypeError: right-hand side of 'in' should be an object, got undefined
pick
src/app/node_modules/@instructure/ui-utils/lib/react/passthroughProps.js:77

  74 | 
  75 | while (++idx < len) {
  76 |   key = keys[idx];
> 77 |   if (key in obj) {
  78 |     res[key] = obj[key];
  79 |   }
  80 | }

@dnehring
Copy link
Contributor Author

dnehring commented Dec 3, 2018

Caleb, I added volumes for the container, so that should resolve the issue you experienced.

fixes CM-604

test plan:
dc build is successful
dc up allows hitting viewer.ccv.docker
@cguanzon cguanzon merged commit ead7068 into master Dec 3, 2018
@cguanzon cguanzon deleted the dockerfile branch December 3, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants